fix(dispatcher): add per-workflow locking to prevent run ID race conditions#11
Merged
Merged
Conversation
…itions When multiple groups trigger the same workflow (owner/repo/workflow_id), there was a race condition where jobs could get incorrect run IDs due to timestamp-based matching in a shared time window. Add per-workflow-template locking that: - Acquires a mutex keyed by owner/repo/workflow_id before dispatching - Waits inline (up to 60s) for run ID to be matched after trigger - Releases lock only after run ID is found or timeout This ensures sequential dispatch for jobs targeting the same workflow, preventing run ID cross-matching between concurrent dispatches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
owner/repo/workflow_idProblem
When multiple groups (A, B) trigger the same workflow (
owner/repo/workflow.yaml), there was a race condition:GitHub's
workflow_dispatchAPI returns204 No Contentwith no run ID, so the system must poll and match by timestamp. Without locking, concurrent dispatches to the same workflow could get each other's run IDs.Solution
Add per-workflow locking with inline run ID matching:
owner/repo/workflow_idThis ensures only one job at a time can dispatch and match a specific workflow template.
Test plan